Basil Coding Technical Search Improvements
Hey Basil Team,
There's a lot of issues with the way the current search system that breaks under various inputs, searches, and devices internally (not graphically).
If you attempt to search with nothing put into the search box, it causes a 404 error as well as a broken search address. This can be resolved by adjusting how you currently have the query written either in your form or in the .htaccess.
Secondly, if any searches contain a period, it will automatically break the search and cause a 404 error. This is because the .htaccess is not properly set up and when there is a period, it thinks everything after it is an file extension. An example would be searching for basilmarket.com. As there is not a file called "basilmarket.com", the search breaks and it gives a 404 error. A fix to this would be to adjust the rewriting for the search directory, as well as adjusting how the query is sent through .htaccess to always know that the file is .php and that everything after the /search/type/ part is the search query and nothing else.
You could also add a check on the search page if a search query is null or empty (nothing inputted) and return the not found page properly.
For example:
<?php
$search = $_GET['searchrequest'];
if (isset($search)) {
?>
-error page here-
<?php
}
?>
-no checks for sql injections-
Hoping for a response.
5 Comments • Newest first
I don't think the search engine has ever worked as it was intended/supposed to. In any case I don't think very many people use it.
regardless, it would be better to send a ticket to mr.b, although there's no guarantee he'll answer it.
even if he does, it'll probably take a year or two before he gets around to it.
[quote=Skyenets]I've often found that suggesting things like this are a lost cause. You are brave young little Tyler.[/quote]
*does a dance*
I've often found that suggesting things like this are a lost cause. You are brave young little Tyler.
Ah, just thought it was better here because I wasn't sure if others were having the same issue and nah, just trying to help since Mr.B has helped me in the past.
[b]Edit:[/b] Hmm, seems like it's more of an issue of escaping characters correctly. (typing in a ' or " causes url deformations).
Example: http://www.basilmarket.com/search/auction//&quot;help/&quot;
Getting ahead of ourselves are we? Making Basilmarket like maple.me?
Joking.
But anyways, since the ultimate target is Mr. Basil, it would be better to file a ticket.
I guess a moderator could send it in, but I'm not sure how many moderators are familiar in this area of expertise. Perhaps Bobr...